buffer: use Utf8LengthV2() instead of Utf8Length() #58156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Utf8Length()` is deprecated and was replaced during the V8 update, but a subsequent commit introduced a new occurrence. Refs: nodejs#58070 Refs: nodejs#58048
tniessen
added
c++
nodejs-github-bot
added
buffer
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58156 +/- ##
==========================================
- Coverage 90.18% 90.17% -0.01%
==========================================
Files 630 630
Lines 186473 186503 +30
Branches 36612 36613 +1
==========================================
+ Hits 168169 168187 +18
- Misses 11116 11121 +5
- Partials 7188 7195 +7
🚀 New features to boost your workflow:
|
Flarna
approved these changes
May 4, 2025
cjihrig
approved these changes
May 4, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
May 4, 2025
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
May 6, 2025
tniessen
added
the
author ready
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4edb139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utf8Length()is deprecated and was replaced during the V8 update (0e68481), but 084a912 introduced a new occurrence.Refs: #58070
Refs: #58048